Skip to content

Fix error on @MaxDepth property #9796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018
Merged

Fix error on @MaxDepth property #9796

merged 1 commit into from
May 18, 2018

Conversation

rebangm
Copy link
Contributor

@rebangm rebangm commented May 18, 2018

Change property annotation according to documentation

@rebangm rebangm closed this May 18, 2018
@rebangm rebangm reopened this May 18, 2018
@xabbuh xabbuh added this to the 3.4 milestone May 18, 2018
@xabbuh
Copy link
Member

xabbuh commented May 18, 2018

Thanks for the fix, but we will need to update the XML and PHP config examples too.

Change property according to documentation
@rebangm
Copy link
Contributor Author

rebangm commented May 18, 2018

Hello,

Yaml and Xml parts updated.

@javiereguiluz
Copy link
Member

@rebangm thanks for fixing this bug in the code of this article ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 2ce9d9c into symfony:3.4 May 18, 2018
javiereguiluz added a commit that referenced this pull request May 18, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fix error on @MaxDepth property

Change property annotation according to documentation

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

2ce9d9c Fix error on @MaxDepth property for annotation, yaml and xml. Change property according to documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants